fix(@schematics/angular): rename app.server.module.ts to app.module.server.ts
#25058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 25, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 25, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 25, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
…e.server.ts` This fixes an issue were we generated files using inconsistent names example `app.server.module.ts` and `app.config.server.ts`.
alan-agius4
force-pushed
the
rename-app-server-module
branch
from
be13eb8
to
5db7650
Compare
alan-agius4
added
target: rc
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 25, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
clydin
approved these changes
Apr 25, 2023
alan-agius4
added
action: merge
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 26, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Apr 26, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058 PR Close #49993
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Apr 26, 2023
`app.server.module` was renamed to `app.module.server`. See: angular/angular-cli#25058 PR Close #49993
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue were we generated files using inconsistent names example
app.server.module.tsandapp.config.server.ts.Note: this was discussed and agree with @AndrewKushnir, @alxhub and @pkozlowski-opensource.